Printable Version of Topic

Click here to view this topic in its original format

Dumpshock Forums _ Dumpshock News, Bug Reports, Feature Requests, & Discussion _ Quoting, Dashes, and Thread Errors...

Posted by: Doctor Funkenstein Jul 26 2007, 04:50 AM

Although it's probably been brought up (I couldn't find anything after a quick search), a bug occured in the http://forums.dumpshock.com/index.php?act=ST&f=26&t=18411&st=100#entry565944 thread.

It apparently had to do with -Nyx-'s name and the automatic quoting feature. I had to edit the linked post in order to fix the thread, and posts didn't start to mess up until the post that followed. Note that the post that followed quoted the same thing I did as well. No idea if it's relevant but thought I'd mentioned it anyway.

Posted by: eidolon Jul 26 2007, 01:52 PM

Hmm. The edit you made must have fixed the more overt problems. Either that or I need coffee worse than I thought.

What was it doing?

Posted by: Doctor Funkenstein Jul 26 2007, 06:00 PM

It did fix it.

It caused the thread to crash from the header of my post and the very first line of it where -Nyx-'s name appeared til, well, the end of the thread. Some kind of [Report] button showed up on the second line as did another button (whose name I can't remember right now). Then there was about an inch or two of grey whitespace, then the blue bar with Next Oldest, Next Newest, etc. and the rest of the page as normal.

But my post and the one following it (the only other one in the thread at the time) were gobbled up. This did not occur, however, until the poster below me posted, including the same quote I was quoting. My post showed up fine prior to that and didn't mess up until the second guy did his.

Oh, and the part where it normally says the poster's name before the quote, it was replaced with normal white text and a <!--QUOTEBEGINS tag, or something like that.

My guess is the page somehow confused the above tag and the - in -Nyx-'s name, causing it to ignore any opening tags in between the two. But I dunno. Should have taken a screen capture and grabbed the source code but I wasn't thinking at the time.

Posted by: Kagetenshi Jul 26 2007, 06:14 PM

The comment tag for quoting is . The key is, though, HTML comments don't end at "-->", or even the closing tag ">" (though the closing tag is required)--they end at any pair of raw dashes. As a result, -Nyx-'s name in the comment was closing the comment, but there was still stuff afterwards, which IIRC is undefined (violation of spec). That's what screwed everything up.

Edit: also, someone got lazy and just commented out the "report" button, which is probably why it showed back up when commenting went all wacky.

Edit^2: also, Dumpshock does something deeply weird with the Location (there's a br that's getting "closed" with a left-curly-bracket). Looks like there's some fixing to do, folks

~J

Posted by: Kagetenshi Jul 26 2007, 11:23 PM

Ok, after breaking the thread briefly I discovered a few things. First off, Safari apparently doesn't break on that spec violation, but it is a spec violation—as I thought, it doesn't like characters that are outside of the comment (terminated by the double dashes) but still inside the comment declaration. I take back what I said about the proper handling being undefined, there may be a "correct" way to render this—IIRC it was one of the things ACID2 tested.

I thought there was a second thing, but I don't remember what it was. I'm not sure what the best fix is—endashes are too large, and escape characters are ugly.

~J

Posted by: mfb Jul 29 2007, 10:30 PM

use this:

CODE

it's the html hyphen character. ugly, but it works.

edit: for fuck's sake. took me three tries to display that.

Posted by: Kagetenshi Jul 30 2007, 01:08 AM

The problem is that the thing what breaks is inside an HTML comment, so it doesn't get rendered—it won't show up as that, just as a literal & #45; . It makes as much sense as anything to replace the dashes with, but it's still ugly.

~J

Posted by: mfb Jul 30 2007, 01:21 AM

QUOTE (-Nyx-)

test

Posted by: mfb Jul 30 2007, 01:22 AM

dang. it actually renders the html special char and then puts it in.

hey, i know what would fix this. just hardcode a space after everybody's name in the autoquote thing. alternatively, fix the html standard (or at least the rendering on all browsers) so that > actually ends the tag, instead of --.

Posted by: eidolon Jul 30 2007, 02:55 PM

FYI: We're hoping that the upcoming software upgrade fixes this problem (and a couple of others). Since it's coming up so soon, it's not really worth trying to hack the code into this version.

If the update doesn't fix it, we'll address it then.

Posted by: Kagetenshi Jul 30 2007, 03:07 PM

QUOTE (mfb @ Jul 29 2007, 08:22 PM)

> does in fact end the tag. -- ends the comment, which is subtly different.

It's invalid, but as mentioned above I'm pretty sure there's a defined failure mode--which FireFox, and possibly others, don't support properly.

It should be noted that there's a reason for > not ending the comment. Imagine you have

<xiphnofunq name="Bob Dole" size="infinite">Some stuff here</xiphnofunq>

and you want to comment it out to test something quickly. The current way comments work lets you make a small change--add a !-- in front of xiphnofunq, and a -- at the end of the /xiphnofunq tag. The other way would require much more significant changes.

It's also consistent with other kinds of special tags, like the <? foo ?> kinds.

~J

Posted by: Doctor Funkenstein Jul 30 2007, 04:41 PM

Wouldn't it just be easier to just remove the addition of a comment completely so that it becomes a non-issue? Or is it being used by the stylesheet or something? I only have a basic understanding of it all.

Posted by: Adam Jul 30 2007, 05:03 PM

We'll be upgrading to the new version of the forum software within the next couple weeks, and after that, if the problem persists in the new version, it will be fixed.

Posted by: Kagetenshi Jul 30 2007, 05:05 PM

QUOTE (Doctor Funkenstein)

I find the comment to be totally awesome because of how much it helps in terms of parsing the source of a thread. Of course, there are better ways to do that, but that requires significant changes--the comment is the easiest way to do it.

~J